Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to get entry expirations #32

Merged
merged 4 commits into from
Sep 14, 2018
Merged

Ability to get entry expirations #32

merged 4 commits into from
Sep 14, 2018

Conversation

raulk
Copy link
Member

@raulk raulk commented Sep 12, 2018

(This PR builds upon #31, and shares the commit history with that one).

This PR introduces the ability to get an entry's expiration as a:

  • datastore standalone operation.
  • as part of a transaction.
  • within an iterator.

Needs to go hand-in-hand with ipfs/go-datastore#96.

Builds will fail until that PR is merged in.

@ghost ghost assigned raulk Sep 12, 2018
@ghost ghost added the status/in-progress In progress label Sep 12, 2018
@raulk raulk changed the title This PR introduces the ability to get an entry's expiration as a: * datastore standalone operation. * as part of a transaction. * within an iterator. Ability to get entry expirations Sep 12, 2018
@raulk raulk requested review from bigs and magik6k September 12, 2018 19:34
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs a rebase, than LGTM

@raulk
Copy link
Member Author

raulk commented Sep 13, 2018

@magik6k no rebase needed, as it was already built upon #31's branch ;-)

@magik6k
Copy link
Member

magik6k commented Sep 13, 2018

Oh, I didn't look at the avoid discarding transaction too early commit sha, thought github would hide it after it was merged to master and if commit hash matched

@raulk
Copy link
Member Author

raulk commented Sep 13, 2018

@magik6k you're right, Github should've hidden it from the UI. Even the diff is wrong. Seems like a bug on their end, WTF. This usually works. I'll rebase to refresh. Thanks for pointing it out.

@raulk raulk merged commit 3110230 into ipfs:master Sep 14, 2018
@ghost ghost removed the status/in-progress In progress label Sep 14, 2018
@raulk raulk deleted the getexpiration branch September 14, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants