Ability to get entry expirations #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
raulk
changed the title
magik6k
reviewed
Sep 13, 2018
|
Oh, I didn't look at the |
|
@magik6k you're right, Github should've hidden it from the UI. Even the diff is wrong. Seems like a bug on their end, WTF. This usually works. I'll rebase to refresh. Thanks for pointing it out. |
raulk
force-pushed
the
getexpiration
branch
from
6eea797
to
e5ca4e1
Compare
bigs
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR builds upon #31, and shares the commit history with that one).
This PR introduces the ability to get an entry's expiration as a:
Needs to go hand-in-hand with ipfs/go-datastore#96.
Builds will fail until that PR is merged in.