Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: apply entire query while locked #129

Merged
merged 2 commits into from
Apr 18, 2019
Merged

sync: apply entire query while locked #129

merged 2 commits into from
Apr 18, 2019

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Apr 17, 2019 •
edited
Loading

This isn't a problem right now (because we only have one non-sync datastore, MapDatastore) but it still makes me nervous.

@ghost ghost assigned Stebalien Apr 17, 2019
@ghost ghost added the status/in-progress In progress label Apr 17, 2019
@Stebalien Stebalien requested a review from magik6k April 17, 2019 19:46
magik6k
magik6k reviewed Apr 17, 2019
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, other than that LGTM.

sync/sync.go Outdated Show resolved Hide resolved
@Stebalien Stebalien requested a review from magik6k April 17, 2019 22:38
@Stebalien Stebalien merged commit b19d692 into master Apr 18, 2019
@Stebalien Stebalien deleted the fix/sync-query branch April 18, 2019 01:32
@ghost ghost removed the status/in-progress In progress label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k