Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter: values are now always bytes #126

Merged
merged 1 commit into from
Apr 17, 2019
Merged

filter: values are now always bytes #126

merged 1 commit into from
Apr 17, 2019

Conversation

Stebalien
Copy link
Member

No description provided.

@ghost ghost assigned Stebalien Apr 9, 2019
@ghost ghost added the status/in-progress In progress label Apr 9, 2019
@Stebalien
Copy link
Member Author

We used to support values with arbitrary types but this added more complexity than it helped (we never actually used arbitrary types, we just had a bunch of type assertions everywhere).

This change removes some vestigial arbitrary type support.

@Stebalien Stebalien requested a review from magik6k April 17, 2019 19:46
@Stebalien Stebalien merged commit ef49136 into master Apr 17, 2019
@ghost ghost removed the status/in-progress In progress label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k