Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datastore): expose datastore Close() #111

Merged
merged 1 commit into from
Jan 28, 2019
Merged

feat(datastore): expose datastore Close() #111

merged 1 commit into from
Jan 28, 2019

Conversation

ywh254
Copy link
Contributor

@ywh254 ywh254 commented Jan 27, 2019

ref #97 Datastores should expose Close()

@ywh254 ywh254 force-pushed the feat/add-datastore-close branch 2 times, most recently from ea46fd8 to 0fd19d9 Compare January 27, 2019 12:29
Stebalien
Stebalien approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All datastores appear to now implement Close so this should be good to go. However, @magik6k should sign off on it.

@Stebalien Stebalien merged commit 3f52705 into ipfs:master Jan 28, 2019
@ywh254 ywh254 deleted the feat/add-datastore-close branch January 29, 2019 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigs bigs bigs left review comments

@Stebalien Stebalien Stebalien approved these changes

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywh254 @bigs @Stebalien @magik6k