Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe behavior of Batching datastores #105

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Describe behavior of Batching datastores #105

merged 1 commit into from
Nov 9, 2018

Conversation

bigs
Copy link
Contributor

@bigs bigs commented Oct 24, 2018

Not sure why I did this in my fork, but here we go!

@ghost ghost assigned bigs Oct 24, 2018
@ghost ghost added the status/in-progress In progress label Oct 24, 2018
schomatis
schomatis approved these changes Oct 25, 2018
View reviewed changes
Copy link

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it sounds to me that part of this documentation is more closely related to the Batch interface than the Batching one, which also encompasses the Datastore interface (but consider this just a personal preference).

@bigs
Copy link
Contributor Author

bigs commented Oct 31, 2018

Closes #102

@schomatis agreed... i'll update that.

@bigs bigs merged commit c834824 into ipfs:master Nov 9, 2018
@bigs bigs deleted the doc/batch branch November 9, 2018 16:34
@ghost ghost removed the status/in-progress In progress label Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@schomatis schomatis schomatis approved these changes

Assignees

@bigs bigs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigs @magik6k @schomatis