Update go-multihash. Now uses registry system. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warpfork
force-pushed
the
multihash-update
branch
from
fa2a44c
to
b4aa7c0
Compare
|
This turns out to be fairly inconsequential, because overall, go-cid still uses the But we still might as well merge this update for the sake of propagating things proactively, afaict. |
Stebalien
previously approved these changes
Mar 15, 2021
|
This needs to depend on a released version of go-multihash, but otherwise SGTM. |
warpfork
force-pushed
the
multihash-update
branch
from
9f983d8
to
6233924
Compare
You can't see it from here, but go-mulithash now uses registry system, so it's reasonably possible to introduce new hashers, and to use (some parts of!) go-multihash without bringing in lots of transitive dependencies. The main package of go-multihash still brings in everything transitively that it did before, so go-cid's transitives aren't shrinking, and no code is changing here... but it's closer. If we did cut over to the new go-mulithash/core, we could make many transitive dependencies become optional.
warpfork
force-pushed
the
multihash-update
branch
from
6233924
to
b4bcfe4
Compare
Stebalien
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are updated to pull in all the hashes that they use, since some of them became optional rather than registered by default. This is what the new side-effecting imports handle.Applications further downstream may require similar imports if they need to use hashes which are no longer registered by default. (These registrations only happen in tests in go-cid, so they're not passed on to downstreams; other applications and libraries must manage their own opt-in.)You can't see it from here, but go-mulithash now uses registry system,
so it's reasonably possible to introduce new hashers, and to use
(some parts of!) go-multihash without bringing in lots of transitive
dependencies.
The main package of go-multihash still brings in everything
transitively that it did before, so go-cid's transitives aren't
shrinking, and no code is changing here... but it's closer.
If we did cut over to the new go-mulithash/core, we could make
many transitive dependencies become optional.