This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Avoid modifying passed in slice of cids #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
fix/race-valid-cid
branch
from
8b5e7c6
to
a978cec
Compare
Kubuxu
pushed a commit
to filecoin-project/lotus
that referenced
this pull request
Jun 24, 2020
Also race fix: depends on ipfs/go-blockservice#65 Resolves #2092, #2099, #2108, #1930, #2110 Signed-off-by: Jakub Sztandera <[email protected]>
Stebalien
approved these changes
Jun 24, 2020
Co-authored-by: Steven Allen <[email protected]>
Stebalien
approved these changes
Jun 24, 2020
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
Avoid modifying passed in slice of cids This commit was moved from ipfs/go-blockservice@622c072
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was causing race detector in lotus to fail.