This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix(network): impl: add timeout in newStreamToPeer call #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
commented
Apr 22, 2021
Comment on lines
+316
to
+317
| tctx, cancel := context.WithTimeout(ctx, connectTimeout) | ||
| defer cancel() |
There was a problem hiding this comment.
Taken from:
go-bitswap/network/ipfs_impl.go
Lines 106 to 116 in a28f6eb
There was a problem hiding this comment.
To clarify, I'm not setting the timeout inside newStreamToPeer or as an argument (like msgToStream does) because the current pattern in Connect is embedding the timeout externally in the context passed to newStreamToPeer. But I can change both if we want to go in another direction.
There was a problem hiding this comment.
This is probably fine for now.
Stebalien
approved these changes
Apr 23, 2021
Comment on lines
+316
to
+317
| tctx, cancel := context.WithTimeout(ctx, connectTimeout) | ||
| defer cancel() |
There was a problem hiding this comment.
This is probably fine for now.
6 tasks
3 tasks
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…reamToPeer-with-timeout fix(network): impl: add timeout in newStreamToPeer call This commit was moved from ipfs/go-bitswap@c13e78b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ipfs/kubo#7972 (comment) for background.
If there is a straightforward 10-line way to test this I can add it, otherwise I'll just leave the fix.