This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix(tests): stabilize unreliable session tests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hannahhoward
force-pushed
the
bugs/stabilize-test-suite
branch
from
08cd6ec
to
a2c38f7
Compare
hannahhoward
force-pushed
the
bugs/stabilize-test-suite
branch
from
a2c38f7
to
78d4f38
Compare
eingenito
suggested changes
Dec 19, 2018
session/session_test.go
Outdated
| @@ -188,14 +186,7 @@ func TestSessionFindMorePeers(t *testing.T) { | |||
| <-cancelReqs | |||
|
|
|||
| // wait long enough for a tick to occur | |||
There was a problem hiding this comment.
This comment isn't quite right anymore, but not that very wrong.
| func (fcm *fakeConnManager) UntagPeer(p peer.ID, tag string) { | ||
| fcm.wait.Done() |
There was a problem hiding this comment.
You might want to defer this or put it after the removal from fcm.taggedPeers otherwise you might get a test failure.
There was a problem hiding this comment.
oh right. got it.
eingenito
approved these changes
Dec 19, 2018
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…uite fix(tests): stabilize unreliable session tests This commit was moved from ipfs/go-bitswap@916de59
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
fix #43
Implementation
Stop relying on timeouts for concurrency and use go sync primitives