This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
avoid copying messages and improve logging #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, reduce the overhead from logging.
dirkmc
approved these changes
Mar 26, 2020
| if err != nil { | ||
| // log.Infof("sendblock error: %s", err) | ||
| log.Errorf("SendMessage error: %s. size: %d. block-presence length: %d", err, msg.Size(), len(env.Message.BlockPresences())) | ||
| log.Debugw("failed to send blocks message", |
There was a problem hiding this comment.
Should this be logged at error level?
There was a problem hiding this comment.
Failing to send to a peer isn't an error for us. They may just not be reachable.
(this is actually why I started digging into this code, I saw this error in a test)
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
avoid copying messages and improve logging This commit was moved from ipfs/go-bitswap@d39c760
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.