Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Bitswap v0.10.1 is causing the lotus sync tests to fail reliably #584

Closed
Stebalien opened this issue Sep 9, 2022 · 4 comments · Fixed by #585
Closed

Bitswap v0.10.1 is causing the lotus sync tests to fail reliably #584

Stebalien opened this issue Sep 9, 2022 · 4 comments · Fixed by #585
Assignees
@Jorropo
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

See filecoin-project/lotus#9279. I'm not sure what's going on here, but this appears to be a pretty significant regression.
@Stebalien Stebalien added the need/triage Needs initial labeling and prioritization label Sep 9, 2022
@Stebalien Stebalien mentioned this issue Sep 9, 2022
Merged
@Jorropo
Copy link
Contributor

Jorropo commented Sep 9, 2022

First issues are seen with v0.10.0 (so this is unrelated to the split and an issue with bumping go-libp2p)

@Jorropo
Copy link
Contributor

Jorropo commented Sep 9, 2022

It's not related to the removal of session uuids in logs (I tested with it back in and it still fails).

@Stebalien
Copy link
Member Author

First issues are seen with v0.10.0 (so this is unrelated to the split and an issue with bumping go-libp2p)

Note: lotus uses libp2p v0.22.0. Did you test with another version?

@Jorropo
Copy link
Contributor

Jorropo commented Sep 9, 2022

Note: lotus uses libp2p v0.22.0. Did you test with another version?

No I just go get github.com/ipfs/[email protected] && go mod tidy && go test -run=TestSyncMining ./chain inside lotus.

Jorropo added a commit to Jorropo/go-bitswap that referenced this issue Sep 13, 2022
@Jorropo
fix: create a copy of the protocol slice in network.processSettings
6a19d46 
Fixes ipfs#584
@Jorropo Jorropo mentioned this issue Sep 13, 2022
Merged
@Jorropo Jorropo self-assigned this Sep 13, 2022
@Jorropo Jorropo added kind/bug A bug in existing code (including security flaws) and removed need/triage Needs initial labeling and prioritization labels Sep 13, 2022
@Jorropo Jorropo moved this to 🎉 Done in IPFS Shipyard Team Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Jorropo Jorropo

Labels
kind/bug A bug in existing code (including security flaws)
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: create a copy of the protocol slice in network.processSettings Jorropo/go-bitswap
2 participants
@Stebalien @Jorropo