Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t0116: implement diretag checks #97

Merged
merged 6 commits into from
Jun 28, 2023
Merged

t0116: implement diretag checks #97

merged 6 commits into from
Jun 28, 2023

Conversation

laurentsenta
Copy link
Contributor

@laurentsenta laurentsenta commented Jun 28, 2023

Closes #93

Rationale:

The API in #96 relies on having implicit coupling (side effects and time) but the rest of the API is declarative.

This is a demo of how we could do the same without changing the API.

I would favor that approach:

  • we don't endorse side-effects and transforming requests at the API level, we'd have a single "rogue" test,
  • the side-effects are simple and explicit (we call Run twice, and we create requests in the regular way)
  • no API change

@laurentsenta laurentsenta marked this pull request as draft June 28, 2023 11:59
@laurentsenta laurentsenta marked this pull request as ready for review June 28, 2023 13:06
@galargh
Copy link
Contributor

galargh commented Jun 28, 2023

👏

@laurentsenta laurentsenta merged commit abd68cc into main Jun 28, 2023
@laurentsenta laurentsenta deleted the feat/t116 branch June 28, 2023 13:13
@laurentsenta laurentsenta mentioned this pull request Jun 28, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port t0116
2 participants