Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t0115: add dir listing test #58

Merged
merged 8 commits into from
Jun 7, 2023
Merged

t0115: add dir listing test #58

merged 8 commits into from
Jun 7, 2023

Conversation

laurentsenta
Copy link
Contributor

No description provided.

@laurentsenta laurentsenta changed the title t0115: add dir listing tes t0115: add dir listing test May 29, 2023
@laurentsenta laurentsenta mentioned this pull request May 29, 2023
Closed
20 tasks
galargh
galargh approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ąęółśćżźń 🚀

fixtures/t0115/dnslink.yml Outdated Show resolved Hide resolved
@laurentsenta
Copy link
Contributor Author

🚀 ąęółśćżźń 🚀

I think you meant %F0%9F%9A%80%20%C4%85%C4%99%C3%B3%C5%82%C5%9B%C4%87%C5%BC%C5%BA%C5%84%20%F0%9F%9A%80

hacdias
hacdias reviewed May 31, 2023
View reviewed changes
tests/t0115_gateway_dir_listing_test.go Outdated
),
Contains(
`/ipfs/<a href="//{{host}}/ipfs/{{cid}}">{{cid}}</a>/<a href="//{{host}}/ipfs/{{cid}}/%C4%85">ą</a>/<a href="//{{host}}/ipfs/{{cid}}/%C4%85/%C4%99">ę</a>`,
u.Host, // TODO: That looks wrong, we link without considering the subdomain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @lidel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked @lidel directly:
we do not redirect to the subdomain URL, because cidv0 would break with normalization,
it's easier to link to the /ipfs/cid for all cases and let the gateway deal with subdomain'ing.

@laurentsenta laurentsenta mentioned this pull request Jun 2, 2023
Open
@laurentsenta laurentsenta merged commit 81be5d5 into main Jun 7, 2023
@laurentsenta laurentsenta deleted the t0115 branch June 7, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

@galargh galargh galargh approved these changes

@lidel lidel Awaiting requested review from lidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurentsenta @hacdias @galargh