-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add t0123 & t0113 - gateway - json - cbor - symlinks #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsenta
changed the title
feat: addt0123 - gateway - json - cbor
feat: add t0123 - gateway - json - cbor
Mar 27, 2023
20 tasks
laurentsenta
force-pushed
the
feat/add-t0123
branch
from
March 27, 2023 14:57
9ecefe3
to
942a53a
Compare
laurentsenta
force-pushed
the
feat/add-t0123
branch
from
March 27, 2023 16:31
a2a3e3d
to
10783f6
Compare
laurentsenta
changed the title
feat: add t0123 - gateway - json - cbor
feat: add t0123 & t0122 - gateway - json - cbor - tar
Mar 29, 2023
galargh
reviewed
Mar 30, 2023
laurentsenta
changed the title
feat: add t0123 & t0122 - gateway - json - cbor - tar
feat: add t0123 & t0122 & t0113 - gateway - json - cbor - tar - symlinks
Mar 30, 2023
laurentsenta
force-pushed
the
feat/add-t0123
branch
from
March 31, 2023 09:34
af82a48
to
fbd32ec
Compare
laurentsenta
changed the title
feat: add t0123 & t0122 & t0113 - gateway - json - cbor - tar - symlinks
feat: add t0123 & t0113 - gateway - json - cbor - symlinks
Mar 31, 2023
Merged
galargh
reviewed
Mar 31, 2023
galargh
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆
laurentsenta
force-pushed
the
feat/add-t0123
branch
from
April 3, 2023 10:26
9396be0
to
db7ee9c
Compare
laurentsenta
commented
Apr 3, 2023
test_cmp expected plain_output | ||
' | ||
*/ | ||
// TODO(lidel): Note we disable this test, we check the payloads above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lidel a note here, we ignore a few tests: they compare two requests with each other.
Instead, we test each request.
laurentsenta
commented
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #26
Tasks:
Notes
bytes equalities
the current test compares kubo and gateway outputs bytes to bytes, for example:
For simple cases, we replace with a higher level comparator (JSON uses
reflect.DeepEqual
),We stick to a bytes-to-bytes comparison with CBOR for now.