Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agregore Demos Open Grant Proposal #245

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

RangerMauve
Copy link
Contributor

Hey folks,

This was developed after talking with @autonome on progressing IPFS and P2P web stuff as a follow on to the Agregore Mobile grant.

This time we'll be building on the existing handlers to provide usable p2p web apps with IPFS as well as tutorials others can follow to create their own versions.

Finally, this is going to be an effort to find pain points in IPFS protocol handlers which we can use to make fixes and make onboarding easier.

@RangerMauve
Copy link
Contributor Author

Hey, I was wondering if there was any ETA on when this could be reviewed. 😁

@ErinOCon
Copy link
Collaborator

ErinOCon commented Dec 2, 2022

HI @RangerMauve, thank you for your proposal and for your patience with our review! I have just sent you an email to discuss next steps.

@RangerMauve
Copy link
Contributor Author

We got all the contracts signed and are getting started on this in full force this week. 😁 We're going to aim to have milestone 1 done by the beginning of January.

@RangerMauve
Copy link
Contributor Author

Folks can follow our project board tracking our progress here: https://github.com/orgs/AgregoreWeb/projects/3

@realChainLife realChainLife merged commit 70da9fc into ipfs:master Jan 17, 2023
@RangerMauve
Copy link
Contributor Author

RangerMauve commented Jan 30, 2023

We're ready to have milestone 1 reviewed.

We've published our announcement blog post here: https://agregore.mauve.moe/blog/2023/01/demos-and-tutorials-announcement

And have got the process we'll be taking for our app/tutorial milestones documented here: https://agregore.mauve.moe/docs/tutorials/process

You can find the new IPFS Protocol Handler docs as well as the copy-pasteable examples here: https://agregore.mauve.moe/docs/ipfs-protocol-handlers

@RangerMauve
Copy link
Contributor Author

Sent out the invoice for milestone 1 :)

@RangerMauve
Copy link
Contributor Author

Hey, we're ready to have milesone 2 reviewed. The blog post with our outcomes can be found here: https://agregore.mauve.moe/blog/2023/07/demos-and-tutorials-first-round

Links to the demos and tutorials can be found there.

cc @autonome ready for review when you have time

@autonome
Copy link
Contributor

autonome commented Aug 7, 2023

Did a review pass here, mostly link and content fixes:

AgregoreWeb/website#40 (comment)

@autonome
Copy link
Contributor

Reviewed the submitted changes, and approved milestone 2 as complete 👍🏼👍🏼👍🏼

@RangerMauve
Copy link
Contributor Author

RangerMauve commented Jan 26, 2024

Ready to have milestone 3 reviewed.

Deliverables:

Bonus: Vincent added some more docs

@autonome
Copy link
Contributor

autonome commented Feb 5, 2024

There are a few minor things noted below that would be great to see cleaned up, and I haven't finished a real "in the wild" test of the chat app, but looking great so far. Marked things needing fixes or testing below with 🛠️.

General notes:

  • Very cool that some of this builds on the editor from the first round
  • I really appreciate the continual focus on simple+vanilla code, reduced to absolute minimum
  • Overall these are great balance of useful basics and hands-on training for beginners

Pubsub chat app

  • 🛠️ I am finding someone to test with me for >1 user

Directory uploader

  • 🛠️ The upload editor goes back to start page after uploading files which is confusing. it did in fact work correctly as the files showed up, but would be great to see this behavior fixed
  • Publishing the site didn't work afaict? nothing happened after waiting quite a while - but that's not the point of this particular tutorial, so nbd, just noting it
  • 🛠️ The conclusion in the retro looks like not finished.

Drag and drop uploader

  • App worked as expected, and hyper worked too, very cool
  • "First, we define a function to simplify document.querySelector" ahaha, it me

@autonome
Copy link
Contributor

autonome commented Feb 5, 2024

Testing confirmed for the chat app. Approved from technical delivery standpoint, one the other fixes above are done by the team.

@RangerMauve
Copy link
Contributor Author

RangerMauve commented Apr 15, 2024

Ready to have milestone 4 reviewed.

Deliverables:

@autonome
Copy link
Contributor

Overall looks good. The content continues to use and build-on the tools and approaches developed in earlier phases, which is awesome. However, a few things are broken that need fixing. The blockers that should be fixed i've noted with ➡️ below.

Ace editor

  • great idea to walk readers through the process of integrating 3rd party libs
  • ➡️ the dev env app is now producing some weird visual artifacts (screenshot below) which makes it not really usable

Image gallery

  • ➡️ the upload bar on bottom is mostly outside viewport, even if resizing windows, and there's no scrollbar

P2Pad

  • ➡️ same issue for bottom bar here, i can't get to it. aha, i can get scrollbar to show if i make it narrow enough that layout is list not quadrants.

Linktree builder

  • ➡️ same bottom bar issue, cannot reach bottom bar to publish because is out of viewport and resize trick doesn't work

Blog post

  • s/Fidde/Fiddle
  • ➡️ the link to the P2Pad tutorial opens a blank white page and downloads the tutorial as .md file
  • ➡️ same issue as above for link to Linktree tutorial, i get a md file download instead of being able to view tutorial

CleanShot 2024-04-18 at 14 50 45@2x

@autonome
Copy link
Contributor

oh, i tested in Agregore 2.5.0

@RangerMauve
Copy link
Contributor Author

Oh! The style issue is a bug in agregore. I'll make a fix tomorrow.

@RangerMauve
Copy link
Contributor Author

@autonome Mind posting a screenshot of the gallary bottom bar being out of view? I am having trouble reproducing it. What OS are you on? Also how wide is your window?

I am also having trouble reproducing the issue with p2pad. It feels like it could be a mac OS issue which I thought I fixed in the past.

@RangerMauve
Copy link
Contributor Author

@autonome Fixed the linking issues, fixed the style issue, released a new version of Agregore that fixes the issue with the content being pushed out of the viewport (good catch!).

https://github.com/AgregoreWeb/agregore-browser/releases/tag/v2.5.1

@autonome
Copy link
Contributor

Rad, updated and tested w/ 2.5.1. All previously reported issues fixed. Now can review the gallery and p2pad tutorials.

Gallery is all good.

P2pad:

  • in step 4, the link to the dnd tutorial is 404
  • should add a link to the final working version, like the other tutorials have

Aside from those last two bits, technical/content review is concluded and m4 is approved from my end.

@RangerMauve
Copy link
Contributor Author

@autonome Fixed! AgregoreWeb/website#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants