Skip to content

Fix sending extra wants #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gammazero merged 2 commits into from
Jul 4, 2025
Merged

Fix sending extra wants #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29ee19a
Fix sending extra wants
gammazero Jul 3, 2025
b13fed1
update changelog
gammazero Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ The following emojis are used to highlight certain changes:
### Removed

### Fixed
- `bitswap/client`: Fix sending extra wants [#968](https://github.com/ipfs/boxo/pull/968)

### Security

Expand Down
6 changes: 3 additions & 3 deletions bitswap/message/message.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,11 @@
func (m *impl) FillWantlist(out []Entry) []Entry {
if cap(out) < len(m.wantlist) {
out = make([]Entry, len(m.wantlist))
} else {
out = out[:0]

Check warning on line 266 in bitswap/message/message.go

View check run for this annotation

Codecov / codecov/patch

bitswap/message/message.go#L266 

Added line #L266 was not covered by tests
}
var i int
for _, e := range m.wantlist {
out[i] = *e
i++
out = append(out, *e)
}
return out
}
Expand Down