bitswap/client: Set DontHaveTimeout MinTimeout to 50ms#965
Conversation
The user says that 25ms helps but not fully resolves the issue of disconnects on spikes. So let's bump this a bit more..
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 61.54% 61.58% +0.04%
==========================================
Files 254 254
Lines 31400 31400
==========================================
+ Hits 19324 19338 +14
+ Misses 10499 10489 -10
+ Partials 1577 1573 -4
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
I am also interested in the setting of this minimum value. Currently, I plan to set it to 200ms for the pure intranet. I want to know where the discussion related to "The user says that 25ms helps" is taking place. |
gammazero
left a comment
There was a problem hiding this comment.
OK. Just wish there was a way to make this less of a magic number.
|
@Dreamacro it comes from ipfs/go-ds-crdt#285 Note that in the "pure internet" I suspect that if a latency is x25 the average probably there is a problem. This affects localhost, where latency is 2ms and a slow disk-read can cause a 25x spike easily. |
The user says that 25ms helps but not fully resolves the issue of disconnects on spikes. So let's bump this a bit more..