bitswap/httpnet: Sanitize allow/denylist inputs#964
Merged
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #964 +/- ##
==========================================
- Coverage 61.65% 61.58% -0.08%
==========================================
Files 254 254
Lines 31397 31409 +12
==========================================
- Hits 19358 19342 -16
- Misses 10470 10493 +23
- Partials 1569 1574 +5
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lidel
approved these changes
Jun 26, 2025
Member
lidel
left a comment
There was a problem hiding this comment.
lgtm, but if we did strings.TrimSpace(h) before doing the checks, it would be less annoying if someone has valid domain but with unnecessary trailing/leading space.
Contributor
Author
True, let me change that before merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.