Skip to content

bitswap/httpnet: limit metric cardinality #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsanjuan merged 8 commits into from
Jun 27, 2025
Merged

bitswap/httpnet: limit metric cardinality #957

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c244112
bitswap/httpnet: limit metric cardinality
hsanjuan Jun 19, 2025
d82d0f1
bitswap/httpnet: new WithMetricsLabelsForEndpoints option.
hsanjuan Jun 25, 2025
4819868
Merge branch 'main' into httpnet-metric-cardinality
hsanjuan Jun 25, 2025
2439949
Explain new metric labelling option in the changelog
hsanjuan Jun 25, 2025
5ac828a
docs: clarify the default behavior
lidel Jun 25, 2025
b051253
changelog: minor correction about http metric cardinality
hsanjuan Jun 27, 2025
dfeb716
Merge remote-tracking branch 'origin/main' into httpnet-metric-cardin…
hsanjuan Jun 27, 2025
4f92c60
Merge remote-tracking branch 'origin/main' into httpnet-metric-cardin…
hsanjuan Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bitswap/network/httpnet/httpnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ func New(host host.Host, opts ...Option) network.BitSwapNetwork {
opt(htnet)
}

// TODO: take allowlist into account!
htnet.metrics = newMetrics(htnet.allowlist)

reqTracker := newRequestTracker()
Expand Down
7 changes: 3 additions & 4 deletions bitswap/network/httpnet/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,9 @@ func newMetrics(endpoints map[string]struct{}) *metrics {

func (m *metrics) updateStatusCounter(method string, statusCode int, host string) {
m.RequestsTotal.Inc()
// Track all for the moment.
// if _, ok := m.trackedEndpoints[host]; !ok {
// host = "other"
// }
if _, ok := m.trackedEndpoints[host]; !ok {
host = "other"
}

var statusStr string

Expand Down
Loading