bitswap/httpnet: limit metric cardinality - #957
Merged
This check has been archived and is scheduled for deletion.
Learn more about checks retention
Codecov / codecov/project
succeeded
Jun 25, 2025 in 0s
61.62% (+0.00%) compared to 5dbf84e
View this Pull Request on Codecov
61.62% (+0.00%) compared to 5dbf84e
Details
Codecov Report
Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.
Project coverage is 61.62%. Comparing base (
5dbf84e) to head (5ac828a).
Report is 5 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| bitswap/network/httpnet/httpnet.go | 14.28% | 6 Missing |
| bitswap/network/httpnet/metrics.go | 80.00% | 2 Missing and 1 partial |
@@ Coverage Diff @@
## main #957 +/- ##
=======================================
Coverage 61.61% 61.62%
=======================================
Files 254 254
Lines 31396 31413 +17
=======================================
+ Hits 19346 19358 +12
- Misses 10479 10483 +4
- Partials 1571 1572 +1 | Files with missing lines | Coverage Δ | |
|---|---|---|
| bitswap/network/httpnet/metrics.go | 92.30% <80.00%> (-4.06%) |
⬇️ |
| bitswap/network/httpnet/httpnet.go | 66.45% <14.28%> (-0.85%) |
⬇️ |
... and 11 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Loading