Conversation
gammazero
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ipdxco/unified-github-workflows/releases/tag/v1.0.24 added support for golangci-lint to the go-check workflow.
Now, if
.golangci.ymlis present in a repository,go-checkwill additionally executegolangci-lint. In PRs,golangci-lintwill be check the diff with the target branch (unless that same PR modifies.golangci.ymlor.github/workflows/go-check.yml), while onpushevents, it will check the entire codebase.In this PR, I added golangci-lint config to this repository. With the added config,
go-checkwill start running the following linters/formatters:This is a list that was initially proposed in #797
A full list of available linters/formatters can be found at:
I also fixed the issues reported by golangci-lint so that the PR can be cleanly merged.