Skip to content

Comments

ci: set up golangci lint in boxo#943

Merged
gammazero merged 4 commits intomainfrom
golangci-lint
Jun 16, 2025
Merged

ci: set up golangci lint in boxo#943
gammazero merged 4 commits intomainfrom
golangci-lint

Conversation

@galargh
Copy link
Contributor

@galargh galargh commented Jun 12, 2025

https://github.com/ipdxco/unified-github-workflows/releases/tag/v1.0.24 added support for golangci-lint to the go-check workflow.

Now, if .golangci.yml is present in a repository, go-check will additionally execute golangci-lint. In PRs, golangci-lint will be check the diff with the target branch (unless that same PR modifies .golangci.yml or .github/workflows/go-check.yml), while on push events, it will check the entire codebase.

In this PR, I added golangci-lint config to this repository. With the added config, go-check will start running the following linters/formatters:

  • gci
  • gofumpt
  • ineffassign
  • misspell
  • unconvert
  • unused
  • usestdlibvars

This is a list that was initially proposed in #797

A full list of available linters/formatters can be found at:

I also fixed the issues reported by golangci-lint so that the PR can be cleanly merged.

@galargh galargh marked this pull request as ready for review June 12, 2025 16:57
@galargh galargh requested review from a team and lidel as code owners June 12, 2025 16:57
@gammazero gammazero merged commit d348734 into main Jun 16, 2025
15 checks passed
@gammazero gammazero deleted the golangci-lint branch June 16, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants