chore(provider): meaningful info level log#940
Merged
Conversation
lidel
commented
Jun 6, 2025
provider/reprovider.go
Outdated
| err := doProvideMany(s.ctx, s.rsys, keys) | ||
| if err != nil { | ||
| log.Debugf("reproviding failed %v", err) | ||
| log.Infof("reproviding failed %v", err) |
Contributor
There was a problem hiding this comment.
Yes, an error is only returned if the DHT provider was unable to provide any record.
guillaumemichel
approved these changes
Jun 8, 2025
Contributor
guillaumemichel
left a comment
guillaumemichel
left a comment
There was a problem hiding this comment.
This change makes sense.
provider/reprovider.go
Outdated
| err := doProvideMany(s.ctx, s.rsys, keys) | ||
| if err != nil { | ||
| log.Debugf("reproviding failed %v", err) | ||
| log.Infof("reproviding failed %v", err) |
Contributor
There was a problem hiding this comment.
Yes, an error is only returned if the DHT provider was unable to provide any record.
Contributor
|
Triage:
|
hsanjuan
reviewed
Jun 13, 2025
Contributor
hsanjuan
left a comment
hsanjuan
left a comment
There was a problem hiding this comment.
I have added some more logging and consolidated logging facilities into provider.
arguably, these are not low-level details from DEBUG level of individual CIDs, but high level start/stop of reprovide event
hsanjuan
force-pushed
the
chore-adjust-provider-log-level
branch
from
f43625c to
6cd7e50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arguably, these are not low-level details from DEBUG level of individual CIDs, but high level INFO about start/stop of reprovide.