Merged
Conversation
This metric mimics requestsInFlight in httpnet. It should tell how many streams are being written or read at a given time, just like in HTTP we measure how many requests are ongoing at a given time. The main insight is knowing with how many "workers" (or how much concurrency) bitswap is using for writing/reading wantlists to/from other hosts. It should roughly match the following, if both things have the same performance: bitswapRequestsInFlight = elementsInWantlist * httpRequestsInFlight However, since httpRequestsInFlight is limited by the number of http workers, it may signal that the number of workers is too low to compete with bitswap and that it should increase to make better use of available concurrent stream capacities.
guillaumemichel
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This metric mimics requestsInFlight in httpnet.
It should tell how many streams are being written or read at a given time, just like in HTTP we measure how many requests are ongoing at a given time.
The main insight is knowing with how many "workers" (or how much concurrency) bitswap is using for writing/reading wantlists to/from other hosts. It should roughly match the following, if both things have the same performance:
bitswapRequestsInFlight = elementsInWantlist * httpRequestsInFlight
However, since httpRequestsInFlight is limited by the number of http workers, it may signal that the number of workers is too low to compete with bitswap and that it should increase to make better use of available concurrent stream capacities.
cc ipshipyard/roadmaps#17