feat(bitswap/client): MinTimeout for DontHaveTimeoutConfig#865
Merged
guillaumemichel merged 1 commit intoipfs:mainfrom Mar 4, 2025
Merged
Conversation
guillaumemichel
approved these changes
Mar 4, 2025
Contributor
guillaumemichel
left a comment
guillaumemichel
left a comment
There was a problem hiding this comment.
Seems fair.
@Wondertan could you add a changelog entry?
Wondertan
force-pushed
the
bitswap/dont-have-min-timeout
branch
from
1a80d09 to
457a179
Compare
Member
Author
|
@guillaumemichel, done |
hsanjuan
added a commit
that referenced
this pull request
Jun 22, 2025
As seen in ipfs/go-ds-crdt#285, and mentioned in #865, the don't have timeout for very low latency setups becomes very low (2.5ms) and cannot handle any sort of spike. In a localhost network with two peers, this causes loss of bitswap connectivity altogether, and is unrecoverable without manually reconnecting, or finding the other peer as provider. Why 200ms? Didn't seem to low nor too high.
hsanjuan
added a commit
that referenced
this pull request
Jun 22, 2025
As seen in ipfs/go-ds-crdt#285, and mentioned in #865, the don't have timeout for very low latency setups becomes very low (2.5ms) and cannot handle any sort of spike. In a localhost network with two peers, this causes loss of bitswap connectivity altogether, and is unrecoverable without manually reconnecting, or finding the other peer as provider. Why 200ms? Didn't seem to low nor too high.
hsanjuan
added a commit
that referenced
this pull request
Jun 24, 2025
As seen in ipfs/go-ds-crdt#285, and mentioned in #865, the don't have timeout for very low latency setups becomes very low (2.5ms) and cannot handle any sort of spike. In a localhost network with two peers, this causes loss of bitswap connectivity altogether, and is unrecoverable without manually reconnecting, or finding the other peer as provider. Why 200ms? Didn't seem to low nor too high.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In low latency environments, the latency estimation becomes very sensitive to sudden spikes in serving time for a Block.
It may happen that Block serving takes more than expected for a ordinary reason, yet triggering don't have timeout to fire a new often duplicate request. The min timeout configuration allows us to set the baseline timeout, beyond which a new request should be fired, substantially minimizing amount of duplicates.