Skip to content

Comments

chore: require go 1.23#848

Merged
galargh merged 7 commits intomainfrom
uci/update-go
Feb 17, 2025
Merged

chore: require go 1.23#848
galargh merged 7 commits intomainfrom
uci/update-go

Conversation

@web3-bot
Copy link
Collaborator

This PR was created automatically by the @web3-bot as a part of the Unified CI project.

BREAKING CHANGE: Updating the Go version to 1.23
BREAKING CHANGE: Updating the Go version to 1.23
BREAKING CHANGE: Updating the Go version to 1.23
BREAKING CHANGE: Updating the Go version to 1.23
@web3-bot web3-bot requested review from a team and lidel as code owners February 16, 2025 12:40
@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.52%. Comparing base (24b6bc3) to head (7c24881).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
+ Coverage   60.37%   60.52%   +0.15%     
==========================================
  Files         243      244       +1     
  Lines       31119    31142      +23     
==========================================
+ Hits        18787    18849      +62     
+ Misses      10648    10615      -33     
+ Partials     1684     1678       -6     
Files with missing lines Coverage Δ
fetcher/testutil/testutil.go 75.86% <ø> (ø)
gateway/assets/test/main.go 0.00% <ø> (ø)
gateway/backend_blocks.go 45.56% <ø> (ø)
gateway/handler_codec.go 61.97% <ø> (ø)
ipld/merkledag/merkledag.go 76.58% <ø> (+0.28%) ⬆️
ipns/pb/record.pb.go 72.22% <ø> (ø)

... and 15 files with indirect coverage changes

@galargh galargh enabled auto-merge (squash) February 17, 2025 16:32
@lidel lidel changed the title ci: uci/update-go chore: require go 1.23 Feb 17, 2025
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a failing windows go.14:

But it seems to be flaky, re-running fixed it:

Let's merge and start dogfooding.

@galargh galargh merged commit 2b56109 into main Feb 17, 2025
15 checks passed
@lidel lidel deleted the uci/update-go branch February 17, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants