fix(bitswap/server): pass context to server engine to register metrics#723
Merged
fix(bitswap/server): pass context to server engine to register metrics#723
Conversation
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #723 +/- ##
==========================================
- Coverage 60.43% 60.40% -0.04%
==========================================
Files 243 243
Lines 31056 31057 +1
==========================================
- Hits 18770 18759 -11
- Misses 10624 10633 +9
- Partials 1662 1665 +3
... and 8 files with indirect coverage changes 🚨 Try these New Features:
|
hsanjuan
approved these changes
Nov 19, 2024
lidel
approved these changes
Nov 19, 2024
Member
There was a problem hiding this comment.
Thanks! I think this is good enough fix problem at hand (metrics regression due to goprocess cleanup that landed with #710).
In future we may want to rework the way bitswap metrics are gathered, but that would be a separate PR (while working on #722 i've identified few places where we do different things, eg. boxo/gateway only uses default registry and ignores duplicate registration errors)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes invalid metrics errors logged by kubo at daemon startup.
Fixes the problem from ipfs/kubo#10567 (review)