Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gateway): ipld.ErrNotFound should result in a 404 #630

Merged
merged 4 commits into from
Jul 30, 2024
Merged

fix(gateway): ipld.ErrNotFound should result in a 404 #630

merged 4 commits into from
Jul 30, 2024

Commits on Jun 24, 2024

  1. fix(gateway): ipld.ErrNotFound should result in a 404 

    In case of blockstore restriction like with --offline or similar restriction, returning a 500 is inapropriate.

It's also going back to a previous gateway behavior (at least in kubo v0.22, possibly later).
    @MichaelMure
    MichaelMure committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    589f56f View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'main' into gw-ipld-notfound

    @lidel
    lidel authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    28f4bc8 View commit details
    Browse the repository at this point in the history

  2. refactor(gateway): match 410 before 404s 

    just a precaution to ensure 410 takes precedence, until we address
ipfs#591
    @lidel
    lidel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e372bc6 View commit details
    Browse the repository at this point in the history

  3. docs: clarify 404 use case

    @lidel
    lidel committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2b6f29f View commit details
    Browse the repository at this point in the history