-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.21.0 #622
Release v0.21.0 #622
Conversation
Merge release v0.20.0
I've noticed some memory and goroutine buildup, linked to that function. It seems like when the context get cancelled, the consumer could be gone, but that function would still attempt to write in the channel and block forever.
* fix(routing/http/contentrouter): return error when no responses are found in FindPeer * fix(routing/http/contentrouter): fix findpeer iteration log message * fix(routing/http/contentrouter): only return information for FindPeer that matches the requested peerID * fix(routing/http/contentrouter): only return information for FindPeer if there are actual addresses * fix(routing/http/contentrouter): switch logging from Warnw -> Warnf where there aren't key pairs * docs: update CHANGELOG.md --------- Co-authored-by: Marcin Rataj <[email protected]>
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## release #622 +/- ##
===========================================
- Coverage 59.83% 59.81% -0.02%
===========================================
Files 239 238 -1
Lines 29961 29984 +23
===========================================
+ Hits 17928 17936 +8
- Misses 10419 10431 +12
- Partials 1614 1617 +3
|
This comment was marked as resolved.
This comment was marked as resolved.
go get -t -u ./...
Suggested version: Changes in (empty)
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
Ok, took some notes in #623 on the process, but no blockers, all green. Shipping and bubbling up to kubo/rainbow/someguy, so we can tag releases of the last two next week. |
This is me following the process from https://github.com/ipfs/boxo/blob/main/RELEASE.md#release-process (minus creating issue with the checklist, I'm doing the checklist below).
Initial impression: we could simplify a lot of manual labor by switching to release-please, and doing patch releases if needed by hand, rather than doing everything by hand. We will discuss once this one ships the old way.
release-vX.Y.Z
and push itmaster
as base ifZ == 0
release
as base ifZ > 0
release-vX.Y.Z
release-vX.Y.Z
intorelease
Z > 0
, then cherry-pick the necessary commits frommaster
intorelease-vX.Y.Z
usinggit cherry-pick -x <commit>
go get github.com/ipfs/boxo@<commit_hash>
using the commit hash of therelease-vX.Y.Z
branchgo mod tidy
in repo root and indocs/examples/kubo-as-a-library
release-vX.Y.Z
bumping the version inversion.json
tovX.Y.Z
release
, using "Create a Merge Commit", and do not delete therelease-vX.Y.X
branchvX.Y.Z
in the title and bodyrelease
intomain
release
branch