Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pinning): pinning existing CID with different name updates pin #537

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 8, 2024

Follow up of #525. This closes ipfs/kubo#10277.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a391d02) 65.56% compared to head (89bf1f8) 65.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   65.56%   65.37%   -0.20%     
==========================================
  Files         207      204       -3     
  Lines       25579    25519      -60     
==========================================
- Hits        16772    16682      -90     
- Misses       7330     7355      +25     
- Partials     1477     1482       +5     
Files Coverage Δ
pinning/pinner/pin.go 32.35% <ø> (ø)
pinning/pinner/dspinner/pin.go 58.71% <28.57%> (-0.20%) ⬇️

... and 17 files with indirect coverage changes

@hacdias hacdias self-assigned this Jan 8, 2024
@hacdias hacdias requested a review from lidel January 8, 2024 10:44
@hacdias hacdias marked this pull request as ready for review January 8, 2024 10:45
@hacdias hacdias requested a review from a team as a code owner January 8, 2024 10:45
@hacdias hacdias merged commit d13d712 into main Jan 9, 2024
13 checks passed
@hacdias hacdias deleted the pin-add-overwrite-name branch January 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

pins: allow 'ipfs pin add --name' to override name
2 participants