Skip to content

fix: fix electron detection #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2020
Merged

fix: fix electron detection #520

merged 2 commits into from
Feb 14, 2020

Conversation

@hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Feb 14, 2020 •
edited
Loading

works

@hugomrdias hugomrdias changed the title feat: removes a bunch of deps and a few cleanups fix: pin electron to 6 Feb 14, 2020
achingbrain
achingbrain approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like to know why self stopped being a thing in Electron.

@hugomrdias hugomrdias changed the title fix: pin electron to 6 fix: fix electron detection Feb 14, 2020
@hugomrdias hugomrdias merged commit 0b911ec into master Feb 14, 2020
@hugomrdias hugomrdias deleted the fix/electron branch February 14, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugomrdias @achingbrain