fix: remove package-lock before generating npm-shrinkwrap file #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npm shrinkwrap` renames your `package-lock.json` if present, this includes project dev deps which npm seems to be installing even though the published module with the shrinkwrap file is a dependency. If we install with the `--production` flag, then remove the `package-lock.json` file and *then* run shrinkwrap, no dev deps are included in the shrinkwrap file. This only affects npm, yarn seems to do the right thing. Fixes #516
alanshaw
approved these changes
Feb 13, 2020
Member
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
Nice, we should get this merged asap and get a patch release out on 0.41.
hugomrdias
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm shrinkwraprenames yourpackage-lock.jsonif present, this includes project dev deps which npm seems to be installing even though the published module with the shrinkwrap file is a dependency.If we install with the
--productionflag, then remove thepackage-lock.jsonfile and then run shrinkwrap, no dev deps are included in the shrinkwrap file.This only affects npm, yarn seems to do the right thing.
Fixes #516