Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/lint.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,21 @@ function checkDependencyVersions () {
Object.keys(pkg[key]).forEach(name => {
const version = pkg[key][name]

if (/^(?!~)([<>=^]{1,2})[0]/.test(version)) {
if (/^(?!~)([<>=^]{1,2})0\.0/.test(version)) {
badVersions.push({
type,
name,
version,
message: 'development (e.g. < 1.0.0) versions should start with a ~'
message: 'early versions (e.g. < 0.1.0) should start with a ~ or have no range'
})
}

if (/^(?![~^])([<>=]{1,2})0/.test(version)) {
badVersions.push({
type,
name,
version,
message: 'development versions (e.g. < 1.0.0) should start with a ^ or ~'
})
}

Expand Down
30 changes: 28 additions & 2 deletions test/lint.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ describe('lint', () => {
it('succeeds when package.json contains dependencies with good versions', function () {
return dependenciesShouldPassLinting({
'some-unstable-dep': '~0.0.1',
'some-dev-dep': '^0.1.0',
'some-other-dev-dep': '~0.1.0',
'some-stable-dep': '^1.0.0',
'some-pinned-dep': '1.0.0'
})
Expand Down Expand Up @@ -89,9 +91,33 @@ describe('lint', () => {
})
})

it('fails when package.json contains dependencies with <= for unstable deps', function () {
it('fails when package.json contains dependencies with >= for unstable deps', function () {
return dependenciesShouldFailLinting({
'some-dep': '<=0.0.1'
'some-dep': '>=0.0.1'
})
})

it('fails when package.json contains dependencies with <= for development deps', function () {
return dependenciesShouldFailLinting({
'some-dep': '<=0.1.0'
})
})

it('fails when package.json contains dependencies with > for development deps', function () {
return dependenciesShouldFailLinting({
'some-dep': '>0.1.0'
})
})

it('fails when package.json contains dependencies with < for development deps', function () {
return dependenciesShouldFailLinting({
'some-dep': '<0.1.0'
})
})

it('fails when package.json contains dependencies with >= for development deps', function () {
return dependenciesShouldFailLinting({
'some-dep': '>=0.1.0'
})
})

Expand Down