Merged
Conversation
The `pre-push` package always runs `npm test` even if there is no `pre-push` section in your package.json. By switching to the `git-validate` package, running pre push hooks is completely opt-in. Nothing will be run if there is no `pre-push` section. This doesn't change the behaviour of repositories that have some `pre-push` targets set, as `git-validate` uses the same syntax as `pre-push`. This change relates to #242.
ghost
assigned
Member
Author
|
I've tested what happens with the pre-push hooks when you upgrade AEgir with this patch applied. It will correctly remove the |
alanshaw
approved these changes
Jun 27, 2018
Member
|
@victorbjelkholm can you merge and release this one? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pre-pushpackage always runsnpm testeven if there is nopre-pushsection in your package.json. By switching to the
git-validatepackage,running pre push hooks is completely opt-in. Nothing will be run if there
is no
pre-pushsection.This doesn't change the behaviour of repositories that have some
pre-pushtargets set, as
git-validateuses the same syntax aspre-push.This change relates to #242.