Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(usage): Use express server #20

Merged
merged 6 commits into from
Mar 17, 2022
Merged

docs(usage): Use express server #20

merged 6 commits into from
Mar 17, 2022

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Feb 9, 2022

The original instructions were outdated and incorrect and started up two servers: one express server inside the mock-ipfs-pinning-service's setup call, and one via http.

This resulted in any requests going to the http server, which has no logic/code behind it and would timeout on requests.

@SgtPooki SgtPooki requested a review from lidel February 9, 2022 20:56
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Small nit: this is a lot of code to put in README 🙈 – any way we can condense this a bit?

If not, perhaps "CLI Usage" above "Code Usage" as it is what most people will use on CI anyway.

also make code example more concise
@SgtPooki
Copy link
Member Author

@lidel how does it look now? see a9ef703

@SgtPooki SgtPooki requested a review from lidel March 14, 2022 20:48
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidel lidel merged commit bd055a3 into main Mar 17, 2022
@lidel lidel deleted the docs-usage-fix branch March 17, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants