Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for window.ipfs.enable({commands, experiments}) #1

Closed
2 tasks done
lidel opened this issue Jun 11, 2019 · 0 comments · Fixed by #5
Closed
2 tasks done

Add support for window.ipfs.enable({commands, experiments}) #1

lidel opened this issue Jun 11, 2019 · 0 comments · Fixed by #5
Assignees
@lidel

Comments

@lidel
Copy link
Member

lidel commented Jun 11, 2019 •
edited
Loading

Context

Synchronous API at window.ipfs (v1) is being deprecated in favor of async window.ipfs.enable (v2) that supports asking for multiple permissions in bulk (details: ipfs/ipfs-companion#589)

TODO

  • support for asynchronous window.ipfs.enable
  • support passing commands and experiments to window.ipfs.enable
    • Other providers may want to add support for those in the future, so those could be top-level config options.

Prior Art

window.ipfs-fallback: code+tests
@lidel lidel mentioned this issue Jun 11, 2019
Closed
8 tasks
@lidel lidel self-assigned this Aug 17, 2019
lidel added a commit that referenced this issue Aug 26, 2019
@lidel
feat: support window.ipfs.enable()
5f8deb5 
Closes #1

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
@lidel lidel mentioned this issue Aug 26, 2019
Merged
2 tasks
@lidel lidel closed this as completed in #5 Sep 2, 2019
lidel added a commit that referenced this issue Sep 2, 2019
@lidel
feat: support window.ipfs.enable() (#5)
b720386 
Closes #1

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support window.ipfs.enable() ipfs-shipyard/ipfs-provider
1 participant
@lidel