Conversation
6 tasks
whizzzkid
approved these changes
Jan 18, 2023
Collaborator
whizzzkid
left a comment
whizzzkid
left a comment
There was a problem hiding this comment.
the web analytics sdk looks like cjs, which may not be importable by node as such, if this works it works, but this should be reported to countly, maybe they wanna ship an ESM too.
CI on companion was flaky, re-run fixed it.
whizzzkid
reviewed
Jan 18, 2023
| private readonly metricsService: T | ||
|
|
||
| constructor ({ autoTrack = true, url = COUNTLY_API_URL, appKey }: MetricsProviderConstructorOptions) { | ||
| constructor ({ autoTrack = true, url = COUNTLY_API_URL, appKey, metricsService }: MetricsProviderConstructorOptions<T>) { |
Collaborator
There was a problem hiding this comment.
opt: long lines can be split
Suggested change
| constructor ({ autoTrack = true, url = COUNTLY_API_URL, appKey, metricsService }: MetricsProviderConstructorOptions<T>) { | |
| constructor ({ | |
| autoTrack = true, | |
| url = COUNTLY_API_URL, | |
| appKey, | |
| metricsService | |
| }: MetricsProviderConstructorOptions<T>) { |
Member
Author
There was a problem hiding this comment.
Usually the lint will fix this when it needs breaking out. We shouldn't need to worry about style things like this since our build does it (should do it?) for us.
And if we want it to be broken up earlier, we should update rules so that it happens automatically.
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
whizzzkid
added a commit
that referenced
this pull request
Jan 18, 2023
* main: chore(release): 1.1.0 [skip ci] feat: export for browser and node chore: fix ipfs-companion import error (#60)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the error at https://github.com/ipfs/ipfs-companion/actions/runs/3915854281/jobs/6694404888. it's required to get CI passing at ipfs/ipfs-companion#1117