This repository was archived by the owner on Aug 12, 2020. It is now read-only.
fix: build & export interop with go-ipfs for small file raw leaves#228
Merged
achingbrain merged 2 commits intoipfs-inactive:masterfrom Aug 23, 2018
Merged
fix: build & export interop with go-ipfs for small file raw leaves#228achingbrain merged 2 commits intoipfs-inactive:masterfrom
achingbrain merged 2 commits intoipfs-inactive:masterfrom
Conversation
For files smaller than max chunk size and raw leaves true, go-ipfs will create a single node that is a raw buffer. Prior to this PR, js-ipfs created a unixfs file node who's data was the raw buffer. This resulted in different hashes for the same file. This PR changes the builder to do the same thing as go-ipfs and adds a resolver to the exporter that allows the exporter to export a node that is a single raw buffer (so that you can `ipfs cat [CID w codec raw]` as you can in go-ipfs). License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned
achingbrain
suggested changes
Aug 23, 2018
Collaborator
achingbrain
left a comment
achingbrain
left a comment
There was a problem hiding this comment.
Code coverage has decreased slightly with this PR - I think it's because of the copy/pasted validation for offset/length/etc in the new raw node exporter. Maybe pull this into a separate function shared with the file exporter to reduce the duplication?
Also fixes an issue with the file resolver and 0 length export. License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
Contributor
Author
|
👍 now? :D |
Collaborator
|
Released in v0.32.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For files smaller than max chunk size and raw leaves true, go-ipfs will create a single node that is a raw buffer. Prior to this PR, js-ipfs created a unixfs file node who's data was the raw buffer. This resulted in different hashes for the same file.
This PR changes the builder to do the same thing as go-ipfs and adds a resolver to the exporter that allows the exporter to export a node that is a single raw buffer (so that you can
ipfs cat [CID w codec raw]as you can in go-ipfs).I was going to write an interop test but it's already here and this PR should aid that branch to pass.
refs ipfs/js-ipfs#1523