This repository was archived by the owner on Aug 12, 2020. It is now read-only.
Add support for rabin fingerprinting chunk algorithm#222
Closed
dordille wants to merge 1 commit intoipfs-inactive:masterfrom
Closed
Add support for rabin fingerprinting chunk algorithm#222dordille wants to merge 1 commit intoipfs-inactive:masterfrom
dordille wants to merge 1 commit intoipfs-inactive:masterfrom
Conversation
This is required to have feature parity with go-ipfs which supports rabin chunking algorithm.
Rabin chunker supports the following `chunkerOptions`
minChunkSize: {integer}
avgChunkSize: {integer}
maxChunkSize: {integer}
polynomial: {string}
window: {integer}
Rabin chunker uses the same defaults defined by go-ipfs-chunker.
Supports ipfs/js-ipfs#1283
License: MIT
Signed-off-by: Dan Ordille <dordille@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to have feature parity with go-ipfs which supports rabin chunking algorithm.
Rabin chunker supports the following chunkerOptions:
minChunkSize,avgChunkSize,maxChunkSize,polynomial,window. Defaults for these options are the same as those defined by ipfs/go-ipfs-chunker.I have opened a PR against the rabin library to allow for these parameters to be modified from javascript, dat-ecosystem-archive/rabin/pull/24.
Supports ipfs/js-ipfs#1283