Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

feat(block.rm): add block remove functionality#1026

Closed
Prabhakar-Poudel wants to merge 1 commit intoipfs-inactive:masterfrom
Prabhakar-Poudel:feat/block-rm
Closed

feat(block.rm): add block remove functionality#1026
Prabhakar-Poudel wants to merge 1 commit intoipfs-inactive:masterfrom
Prabhakar-Poudel:feat/block-rm

Conversation

@Prabhakar-Poudel
Copy link
Copy Markdown

docs: update readme

fixes #792

License: MIT
Signed-off-by: Prabhakar-Poudel yuvrajzohan@gmail.com

@Prabhakar-Poudel
Copy link
Copy Markdown
Author

@alanshaw

FAIL ./dist/index.min.js: 243.68KB > maxSize 236KB (gzip)

Bundle size has exceeded the maximum. How can I resolve this?

@achingbrain
Copy link
Copy Markdown
Collaborator

maxSize is set in .aegir.js, you may just need to increase that.

@Prabhakar-Poudel Prabhakar-Poudel force-pushed the feat/block-rm branch 2 times, most recently from 022885c to 9653d67 Compare June 3, 2019 15:28
@Prabhakar-Poudel
Copy link
Copy Markdown
Author

maxSize is set in .aegir.js, you may just need to increase that.

Will that break other parts of codebase?
And if we keep it increasing every so often, why not have a decent enough of an estimate?
@achingbrain

docs: update readme

fixes ipfs-inactive#792

License: MIT
Signed-off-by: Prabhakar-Poudel <yuvrajzohan@gmail.com>
@achingbrain
Copy link
Copy Markdown
Collaborator

achingbrain commented Oct 16, 2019

This was implemented in #1123. Sorry, I forgot this was here! Too many repos..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

block.rm() is missing :(

2 participants