This repository was archived by the owner on Mar 10, 2020. It is now read-only.
feat(object): object.put protobuf encoding test #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
|
go-ipfs doesn't like the protobuf I wonder is because it gets stringified to be put on the wire. @whyrusleeping thoughts? |
Contributor
|
Note that we have tests to match the protobufs generated in JS to the ones in Go, byte by byte. Sharing this so that you don't spend time trying to see if the protobuf is correctly formated. |
Contributor
Author
|
This PR is correct, the issue was in js-ipfs-api see this PR for a fix: ipfs-inactive/js-ipfs-http-client#272 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3