This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix(ci): avoid fs clash during ipfs.add* on Windows#523
Closed
Conversation
TravisCI often fails on Windows due to parallel add* clashing with the way Node manages fs access on Windows. Switching to one after should stabilize test suite on Windows by removing surface for those race conditions. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
7 tasks
hugomrdias
approved these changes
Sep 9, 2019
Contributor
|
The fix for this is ipfs/js-datastore-fs#27 |
Contributor
That was merged into 0.8.x branch and ipfs-repo is on 0.9.x |
Collaborator
|
The PR for the 0.9.x branch is ipfs/js-datastore-fs#28 |
Contributor
Author
|
Should we close this, and bubble up the datastore fix instead? |
Contributor
Author
|
Closing, as ipfs/js-ipfs#2304 confirmed this is fixed in js-datastore-fs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes random TravisCI failures on Windows and unblocks ipfs/js-ipfs#2304
Root cause
Windows issue was triggered by parallel
ipfs.add*of the same data:Both
addFromURLandaddadded the same data, touched same files on filesystem, triggering a known problem with Node on Windows and Travis:Fix
One way to fix this type of error is to run as Windows Administrator. It does not seem to be feasible for TravisCI.
Instead, switching to sequential mode of operation removes
addFromURLtests as a surface for file system race conditions on Windows.