Conversation
ghost
assigned
|
|
||
| `callback` must follow `function (err, name) {}` signature, where `err` is an error if the operation was not successful. `name` is a string that contains the IPFS hash. | ||
|
|
||
| `callback` must follow `function (err, result) {}` signature, where `err` is an error if the operation was not successful. `result` is an object that contains the resulting path, such as: |
There was a problem hiding this comment.
Why are there two callback definitions?
|
|
||
| ```JavaScript | ||
| { | ||
| strings: ['/ipns/QmQrX8hka2BtNHa8N8arAq16TCVx5qHcb46c5yPewRycLm'] |
There was a problem hiding this comment.
"strings"? Shall we just return an array here?
There was a problem hiding this comment.
Yes! I got confused here. Both js-ipfs-api and js-ipfs should return only the array in the end!
| ipfs.name.publish(value, { resolve: false }, (err, res) => { | ||
| expect(err).to.not.exist() | ||
|
|
||
| ipfs.name.resolve(nodeId, (err) => { |
There was a problem hiding this comment.
Just so I understand this correctly, when you resolve, you get automatically subscribed to updates? Is there a way to not subscribe?
There was a problem hiding this comment.
When you try to resolve an ipns path and the experimental flag --enable-namesys-pubsub is being used, it will get automatically subscribed. This way, when an ipns record is updated, we will have the most recent version of it stored locally.
For now, there is no way to not subscribe it (if you use the experimental flag), but since it is experimental, we may consider adding a flag for it, in case we enable it by default in the future.
| expect(err).to.not.exist() | ||
| expect(res).to.exist() | ||
| expect(res).to.have.property('canceled') | ||
| expect(res.canceled).to.eql(true) |
There was a problem hiding this comment.
Should we also check this value is no longer in our subs list?
| expect(res.canceled).to.eql(true) | ||
|
|
||
| done() | ||
| }) |
There was a problem hiding this comment.
Suggestion: async waterfall or something?
|
|
||
| const fixture = Object.freeze({ | ||
| data: loadFixture('js/test/fixtures/testfile.txt', 'interface-ipfs-core'), | ||
| cid: 'Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP' |
There was a problem hiding this comment.
IMHO we should just use the CID in the result from add and not hard code it. We're not testing "add" functionality here and if the CID changes in the future (because of changes in default dag layout or cid version for instance) there's fewer things to update in the tests. If you do change this then please also change in the other test files :)
There was a problem hiding this comment.
Will change in both
| expect(err).to.not.exist() | ||
| expect(res).to.exist() | ||
| expect(res).to.have.property('strings') | ||
| expect(res.strings).to.eql(null) |
There was a problem hiding this comment.
It should always be an array.
| expect(err).to.not.exist() | ||
| expect(res).to.exist() | ||
| expect(res).to.have.property('strings') | ||
| expect(res.strings).to.be.an('array').that.does.include(`/ipns/${nodeId}`) |
There was a problem hiding this comment.
Check that it was empty initially?
| expect(res.strings).to.be.an('array').that.does.include(`/ipns/${nodeId}`) | ||
|
|
||
| done() | ||
| }) |
| ``` | ||
|
|
||
| `callback` must follow `function (err, name) {}` signature, where `err` is an error if the operation was not successful. `name` is a string that contains the IPFS hash. | ||
| `callback` must follow `function (err, result) {}` signature, where `err` is an error if the operation was not successful. `result` is an object that contains the resulting path. |
There was a problem hiding this comment.
I believe this was correct - both js-ipfs-api and js-ipfs return only the path.
vasco-santos
force-pushed
the
feat/ipns-over-pubsub
branch
from
1418857 to
08a5b90
Compare
3 participants
PR implemented taking into consideration the most recent documentation of the
go-ipfsAPI on:http://ipfs.io/ipfs/QmPKzWaeHumLuiKLb2Ak67s5kxZ1p6YbnjVKYYfF9hTjzn
This tests aim to be integrated on s-ipfs-api#846 and in a future PR to
js-ipfscontaining theIPNS over Pubsubimplementation.