Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eusure tipset exit #24

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Conversation

hunjixin
Copy link

@hunjixin hunjixin commented Nov 11, 2022

co/node.go Outdated Show resolved Hide resolved
co/selector.go Outdated Show resolved Hide resolved
gen/node-proxy/gen/gen.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #24 (a576e3e) into master (751b1c2) will increase coverage by 0.01%.
The diff coverage is 1.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #24      +/-   ##
=========================================
+ Coverage    4.71%   4.73%   +0.01%     
=========================================
  Files          24      24              
  Lines        3200    3250      +50     
=========================================
+ Hits          151     154       +3     
- Misses       3043    3088      +45     
- Partials        6       8       +2     
Flag Coverage Δ
unittests 4.73% <1.11%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/client.go 0.00% <0.00%> (ø)
cmd/run.go 0.00% <0.00%> (ø)
co/coordinator.go 0.00% <0.00%> (ø)
gen/node-proxy/gen/gen.go 0.00% <0.00%> (ø)
gen/node-proxy/proxygen.go 0.00% <0.00%> (ø)
proxy/local.go 0.00% <0.00%> (ø)
proxy/proxy.go 0.00% <0.00%> (ø)
proxy/unsupport.go 0.00% <0.00%> (ø)
service/dep.go 0.00% <0.00%> (ø)
co/node.go 0.89% <8.69%> (+0.89%) ⬆️
... and 1 more

Copy link

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunjixin hunjixin force-pushed the feat/select_by_tipset_key branch from a576e3e to 38b69d0 Compare November 14, 2022 02:53
@hunjixin hunjixin changed the base branch from master to v0.3.0-pre-rc November 14, 2022 03:11
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@simlecode simlecode merged commit 4255fc6 into v0.3.0-pre-rc Nov 14, 2022
@simlecode simlecode deleted the feat/select_by_tipset_key branch November 14, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants