Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #4759 venus-auth: add docker feature #80

Merged
merged 10 commits into from
Jun 9, 2022
Merged

feat: #4759 venus-auth: add docker feature #80

merged 10 commits into from
Jun 9, 2022

Conversation

LinZexiao
Copy link
Collaborator

Related Issues

filecoin-project/venus#4759

Proposed Changes

add docker features
add github action for automaticly pushing to dockerhub

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build_upload.yml 中的push和pull_request的分支改一下就没问题了
pull_request:
branches:
- main
push:
branches:
- main
- test*

@LinZexiao LinZexiao requested a review from diwufeiwen June 8, 2022 06:23
to listen on master baranch
@codecov-commenter
Copy link

Codecov Report

Merging #80 (f47a2df) into master (896f44f) will decrease coverage by 1.22%.
The diff coverage is n/a.

❗ Current head f47a2df differs from pull request most recent head a9219e9. Consider uploading reports for the commit a9219e9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   30.14%   28.92%   -1.23%     
==========================================
  Files          30       30              
  Lines        2491     2939     +448     
==========================================
+ Hits          751      850      +99     
- Misses       1623     1954     +331     
- Partials      117      135      +18     
Flag Coverage Δ
unittests 28.92% <ø> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/jwtclient/auth_client.go 36.39% <0.00%> (-8.01%) ⬇️
auth/app.go 22.33% <0.00%> (-6.55%) ⬇️
auth/jwt.go 33.09% <0.00%> (-5.75%) ⬇️
storage/badger.go 59.16% <0.00%> (-1.38%) ⬇️
storage/badger_helper.go 60.38% <0.00%> (-0.88%) ⬇️
cli/user.go 0.00% <0.00%> (ø)
cli/token.go 0.00% <0.00%> (ø)
storage/mysql.go 0.00% <0.00%> (ø)
auth/transport.go 55.55% <0.00%> (ø)
auth/route.go 95.89% <0.00%> (+0.30%) ⬆️
... and 2 more

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit c2ff8fd into master Jun 9, 2022
@LinZexiao LinZexiao deleted the docker branch June 10, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants