Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer id is nil #474

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: peer id is nil #474

merged 1 commit into from
Oct 23, 2023

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Oct 23, 2023

关联的Issues (Related Issues)

close #475

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #474 (148bed9) into master (9a8cf5d) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   19.72%   19.69%   -0.03%     
==========================================
  Files         200      200              
  Lines       25880    25889       +9     
==========================================
- Hits         5105     5100       -5     
- Misses      19894    19907      +13     
- Partials      881      882       +1     
Flag Coverage Δ
unittests 19.69% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/client.go 8.69% <0.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

@simlecode simlecode changed the title fix: check peer id is nil fix: peer id is nil Oct 23, 2023
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit ad8a50c into master Oct 23, 2023
1 check passed
@LinZexiao LinZexiao deleted the fix/check-peer-id branch October 23, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[droplet-client] 检查 miner 是否设置 peerid
3 participants