Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support http retrieval #338

Merged
merged 3 commits into from
Jun 15, 2023
Merged

feat: support http retrieval #338

merged 3 commits into from
Jun 15, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

close #336

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #338 (87f6b8f) into master (86a318f) will increase coverage by 0.19%.
The diff coverage is 23.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   20.61%   20.81%   +0.19%     
==========================================
  Files         187      191       +4     
  Lines       22850    23142     +292     
==========================================
+ Hits         4710     4816     +106     
- Misses      17377    17542     +165     
- Partials      763      784      +21     
Flag Coverage Δ
unittests 20.81% <23.28%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/droplet-http/cli.go 0.00% <0.00%> (ø)
cmd/droplet-http/main.go 0.00% <0.00%> (ø)
config/common.go 100.00% <ø> (ø)
retrievalprovider/modules.go 0.00% <0.00%> (ø)
retrievalprovider/provider.go 0.00% <0.00%> (ø)
retrievalprovider/transports.go 0.00% <0.00%> (ø)
cmd/droplet-http/server.go 53.96% <53.96%> (ø)

... and 5 files with indirect coverage changes

types/transports.ipldsch Outdated Show resolved Hide resolved
Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simlecode simlecode merged commit 34a7277 into master Jun 15, 2023
@simlecode simlecode deleted the feat/http-retrieve branch June 15, 2023 01:39
simlecode added a commit that referenced this pull request Jun 15, 2023
hunjixin added a commit that referenced this pull request Jun 15, 2023
Merge pull request #338 from ipfs-force-community/feat/http-retrieve
@Fatman13
Copy link
Contributor

👍👍👍 赞。正好今天 boost 在 venus 里面问了一嘴 venus 的 http 支持怎么样了。

https://filecoinproject.slack.com/archives/CEHHJNJS3/p1686852778678829

@Fatman13 Fatman13 added the C-enhancement Category: feature enhancement label Jun 16, 2023
@simlecode simlecode mentioned this pull request Jul 3, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: feature enhancement
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

support http retrieve / 支持 http 检索
4 participants