feat: #4910 venus-market,venus : add sub command to mannage piece storage #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lint fail because it rely on another unmerged PR in venus repo |
hunjixin
reviewed
Jun 27, 2022
RemovePieceStorage AddFsPieceStorage AddS3PieceStorage
LinZexiao
force-pushed
the
feat/tanlang/addPieceStorage
branch
from
0a1ce19 to
a353159
Compare
17 tasks
diwufeiwen
reviewed
Jul 4, 2022
diwufeiwen
reviewed
Jul 4, 2022
when add piece storage
unified the name of sub command check flag by cctx.IsSet add ArgsUsage comment
LinZexiao
force-pushed
the
feat/tanlang/addPieceStorage
branch
from
46d976f to
2f48692
Compare
hunjixin
reviewed
Jul 4, 2022
cli/piece-storage.go
Outdated
| Aliases: []string{"e"}, | ||
| Usage: "endpoint of the S3 bucket", | ||
| }, | ||
| // access key |
There was a problem hiding this comment.
下面三个量最好使用交互式的输入方式，避免在history里面留下记录
piecestorage/storagemgr.go
Outdated
| @@ -14,8 +15,20 @@ type PieceStorageManager struct { | |||
|
|
|||
| func NewPieceStorageManager(cfg *config.PieceStorage) (*PieceStorageManager, error) { | |||
| var storages []IPieceStorage | |||
| exist := make(map[string]bool) | |||
piecestorage/storagemgr.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (p *PieceStorageManager) ListStorages() types.PieceStorageList { |
There was a problem hiding this comment.
建议名字是ListStorageInfos, 类型同理
PieceStorageList -> PieceStorageInfos ListStorages -> ListStorageInfos
hunjixin
reviewed
Jul 5, 2022
piecestorage/storagemgr.go
Outdated
| @@ -83,3 +114,45 @@ func randStorageSelector(storages []IPieceStorage) (IPieceStorage, error) { | |||
| return storages[rand.Intn(len(storages))], nil | |||
| } | |||
| } | |||
|
|
|||
| func (p *PieceStorageManager) GetStorages() map[string]IPieceStorage { | |||
cli/piece-storage.go
Outdated
| cs.Close() // nolint:errcheck | ||
| }() | ||
|
|
||
| rl := bufio.NewReader(cs) |
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 18.81% 19.09% +0.28%
==========================================
Files 170 172 +2
Lines 17804 18213 +409
==========================================
+ Hits 3349 3478 +129
- Misses 14023 14292 +269
- Partials 432 443 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hunjixin
reviewed
Jul 5, 2022
LinZexiao
force-pushed
the
feat/tanlang/addPieceStorage
branch
from
22a9ad9 to
e45787c
Compare
LinZexiao
force-pushed
the
feat/tanlang/addPieceStorage
branch
from
e45787c to
29f241e
Compare
litai686
pushed a commit
to litai686/venus-market
that referenced
this pull request
Jul 30, 2022
…/feat/dtynn/cgroup_cleanup chore: add a script for cleaning up orphan sub-groups in cgroup:cpuset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
close filecoin-project/venus#4910
Proposed Changes
add subaommand to set piece storage when market is running
AddFsPieceStorage
ListPieceStorage
RemovePieceStorage
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <#issue number> <area>: <change being made>fix: #1234 mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, testarea: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet