fix: expand lock to include check logi

piecestorage/storagemgr.go

@@ -59,6 +59,8 @@ func NewPieceStorageManager(cfg *config.PieceStorage) (*PieceStorageManager, err
 func (p *PieceStorageManager) FindStorageForRead(ctx context.Context, s string) (IPieceStorage, error) {
 	var storages []IPieceStorage
 	p.RLock()
+	defer p.RUnlock()
+
 	for _, st := range p.storages {
 		has, err := st.Has(ctx, s)
 		if err != nil {
@@ -69,7 +71,6 @@ func (p *PieceStorageManager) FindStorageForRead(ctx context.Context, s string)
 			storages = append(storages, st)
 		}
 	}
-	p.RUnlock()
 
 	if len(storages) == 0 {
 		return nil, fmt.Errorf("unable to find piece in storage %s", s)
@@ -81,13 +82,14 @@ func (p *PieceStorageManager) FindStorageForRead(ctx context.Context, s string)
 func (p *PieceStorageManager) FindStorageForWrite(size int64) (IPieceStorage, error) {
 	var storages []IPieceStorage
 	p.RLock()
+	defer p.RUnlock()
+
 	for _, st := range p.storages {
 		//todo readuce too much check on storage
 		if !st.ReadOnly() && st.CanAllocate(size) {
 			storages = append(storages, st)
 		}
 	}
-	p.RUnlock()
 
 	if len(storages) == 0 {
 		return nil, fmt.Errorf("unable to find enough space for size %d", size)
@@ -98,21 +100,21 @@ func (p *PieceStorageManager) FindStorageForWrite(size int64) (IPieceStorage, er
 
 func (p *PieceStorageManager) AddMemPieceStorage(s IPieceStorage) {
 	p.Lock()
+	defer p.Unlock()
+
 	p.storages[s.GetName()] = s
-	p.Unlock()
 }
 
 func (p *PieceStorageManager) AddPieceStorage(s IPieceStorage) error {
 	// check if storage already exist in manager and it's name is not empty
-	p.RLock()
+	p.Lock()
+	defer p.Unlock()
+
 	_, ok := p.storages[s.GetName()]
-	p.RUnlock()
 	if ok {
 		return fmt.Errorf("duplicate storage name: %s", s.GetName())
 	}
-	p.Lock()
 	p.storages[s.GetName()] = s
-	p.Unlock()
 	return nil
 }
 
@@ -128,15 +130,14 @@ func randStorageSelector(storages []IPieceStorage) (IPieceStorage, error) {
 }
 
 func (p *PieceStorageManager) RemovePieceStorage(name string) error {
-	p.RLock()
+	p.Lock()
+	defer p.Unlock()
+
 	_, exist := p.storages[name]
-	p.RUnlock()
 	if !exist {
 		return fmt.Errorf("storage %s not exist", name)
 	}
-	p.Lock()
 	delete(p.storages, name)
-	p.Unlock()
 	return nil
 }