Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vsm: cli): Refactor renew and remove extend #582

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

0x5459
Copy link
Collaborator

@0x5459 0x5459 commented Feb 1, 2023

关联的Issues (Related Issues)

closes #391, closes #567, closes #578

改动 (Proposed Changes)

  • add sectors renew/extend --only-cc flag
  • add renew max-sectors flag
  • removes extend subcommand
  • renames renew to extend. also includes some minor refactoring

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合 Venus 项目管理规范中关于 PR 的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的 commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@0x5459 0x5459 requested review from diwufeiwen and remakeZK February 1, 2023 04:41
@0x5459 0x5459 added this to the v0.6.0 milestone Feb 1, 2023
@0x5459 0x5459 self-assigned this Feb 1, 2023
@0x5459 0x5459 added the breaking change This PR or issue contains breaking changes label Feb 1, 2023
- add sectors renew/extend --only-cc flag
- add renew max-sectors flag
- removes extend subcommand
- renames renew to extend. also includes some minor refactoring
@0x5459 0x5459 force-pushed the feat/0x5459/minor_refactoring_cli_sectors_renew branch from 09697af to 4fb1cbe Compare February 1, 2023 05:24
Copy link
Contributor

@remakeZK remakeZK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remakeZK remakeZK merged commit 3734a7c into main Feb 1, 2023
@remakeZK remakeZK deleted the feat/0x5459/minor_refactoring_cli_sectors_renew branch February 1, 2023 05:32
@0x5459 0x5459 mentioned this pull request Feb 3, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This PR or issue contains breaking changes
Projects
Status: In Review
2 participants