Migrate to Python3 #70
Conversation
Fix PDF export
There was a problem hiding this comment.
Thank you SO MUCH for tackling this!
I've just added a few suggestions while quickly having a look. I look forward to merge your patch soon, but please give me some time to properly review it, eventually add some fixes about shortcomings you've outlined at GH-68, and address further details.
setup.py
Outdated
| dependency_links=[ | ||
| 'https://github.com/ip-tools/mongodb_gridfs_beaker/archive/0.6.0dev1.tar.gz#egg=mongodb_gridfs_beaker', | ||
| 'https://github.com/ip-tools/mechanize/archive/v0.4.3dev2.tar.gz#egg=mechanize-0.4.3dev2', | ||
| #'https://github.com/dagwieers/unoconv/archive/master.tar.gz#egg=unoconv-0.8.2', | ||
| ], |
There was a problem hiding this comment.
Note to self: In order to be able to run a general availability release, and publish the package to PyPI, we will need to resolve those dependencies beforehand.
There was a problem hiding this comment.
Can it be solved by including submodules in the source path?
There was a problem hiding this comment.
We could vendorize the dependencies, but we still will need to port them over to Python 3. I think there is not so much work to do. On mongodb_gridfs_beaker, I made a start at 1, which is probably already pulled in here. On mechanize, a minor patch was required, but it's already upstream, see 2.
Footnotes
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 51.75% 44.28% -7.47%
==========================================
Files 100 100
Lines 7770 7878 +108
==========================================
- Hits 4021 3489 -532
- Misses 3749 4389 +640
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Before, the system would happily use empty credentials induced by CI when running from foreign repositories, where the GitHub secrets attached to the repository are not active, but the GHA workflow configuration still sets the environment variables - to empty values.
For the migration, I started from the last state of the main branch, then applied the patches from the python3 branch.
Thus the last commits from the branch peds are not used,